giving time for the device to be discovered after burning fw #13961
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nir-Az
reviewed
Apr 24, 2025
unit-tests/test-fw-update.py
Outdated
| @@ -242,6 +242,20 @@ def find_image_or_exit( product_name, fw_version_regex = r'(\d+\.){3}(\d+)' ): | |||
| time.sleep(3) # MIPI devices do not re-enumerate so we need to give them some time to restart | |||
| devices.query( monitor_changes = False ) | |||
| sn_list = devices.all() | |||
| sn_list_size = len(sn_list) | |||
| if sn_list_size == 0: | |||
| retries = 10 | |||
There was a problem hiding this comment.
30 seconds timeout is too long IMO.
Maybe we can do 5x2 sec?
There was a problem hiding this comment.
It is 3 seconds at each iteration, and it usually succeeds at the third iteration.
30 seconds is only the worst case - I agree it should not occur...
So you mean 5 iterations of 2 seconds each - OK.
Nir-Az
reviewed
Apr 25, 2025
unit-tests/test-fw-update.py
Outdated
| @@ -242,6 +244,20 @@ def find_image_or_exit( product_name, fw_version_regex = r'(\d+\.){3}(\d+)' ): | |||
| time.sleep(3) # MIPI devices do not re-enumerate so we need to give them some time to restart | |||
| devices.query( monitor_changes = False ) | |||
| sn_list = devices.all() | |||
| sn_list_size = len(sn_list) | |||
There was a problem hiding this comment.
Don't we want to do it in the rs-fw-update tool like we do on usb?
And print the new device version ?
remibettan
force-pushed
the
fixing-custom-d400-fw-python-test
branch
3 times, most recently
from
b14b767 to
c0a5a26
Compare
remibettan
force-pushed
the
fixing-custom-d400-fw-python-test
branch
from
1386509 to
da6881b
Compare
Nir-Az
reviewed
Apr 29, 2025
| @@ -31,6 +31,14 @@ | |||
|
|
|||
| using rsutils::json; | |||
|
|
|||
| std::condition_variable cv; | |||
There was a problem hiding this comment.
What is the reason to move from main to global?
access from any place?
There was a problem hiding this comment.
yes - especially from the code that I have moved from main to private methods
remibettan
merged commit 684cf10
into
IntelRealSense:development
25 of 26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracked by: RSDSO-20159